-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spring Data Respository를 사용한 Redis 캐싱 수행시 Hikaricp Conneciton을 사용하는 문제 해결 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- TTL을 1일로 설정하고 id와 유저 정보를 각각 key와 value로 설정 - MemberPrincipal에 UserRole 필드를 추가하여 authorities 대신 캐싱되도록 반영 - 변경점 모두 수정
src/main/java/freshtrash/freshtrashbackend/FreshTrashBackendApplication.java
Show resolved
Hide resolved
src/main/java/freshtrash/freshtrashbackend/controller/AuctionController.java
Show resolved
Hide resolved
src/main/java/freshtrash/freshtrashbackend/controller/ProductController.java
Show resolved
Hide resolved
src/main/java/freshtrash/freshtrashbackend/dto/security/MemberPrincipal.java
Show resolved
Hide resolved
- 유저 정보 캐싱 코드를 수정하면서 변경된 부분에 대한 테스트 코드를 수정
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍️ 이 PR을 통해 해결하려는 문제
✨ 이 PR에서 핵심적으로 변경된 사항
RedisConfig 수정
@Cahceable
,@CacheEvict
어노테이션을 사용하여 캐시를 저장/삭제합니다.MemberPrincipal에 UserRole 필드를 추가하여 authorities 대신 캐싱되도록 반영했습니다.
적용 결과: 상세 게시글 조회 요청을 100회 수행했을 때 304 -> 205개로 Hikaricp Connection을 얻는 횟수가 줄어들었습니다.
🔖 핵심 변경 사항 외에 추가적으로 변경된 부분
📌 PR 진행 시 이러한 점들을 참고해 주세요
Issue Tags