You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is based on comments in frictionlessdata/datapackage#487 and tries to apply the least invasive and non-breaking changes. It extends default datetime formatting although it keeps simple date and time.
It might be too late to remove pattern and any formats because of backward-compatibility requirements but what if we add a note that it's RECOMMENDED always use default formats (or even using SHOULD)?
Thanks @peterdesmet! It's been updated based on your comments!
@khusmann @ezwelty @pwalsh @PietrH @nichtich
Can you please take a look -- this change is also a good candidate to be accepted. Currently, it misses only 2 votes
If any cannot be removed, I would add a SHOULD (not), because its use can lead to ambiguous data, which is exactly the situation a metadata spec is supposed to fix.
pattern complicates automatic parsing of the data by software tools, but at least it serves the purpose of recording an explicit format, so I would only add a (not) RECOMMENDED. To me this falls in the same category as numeric groupChar in allowing vernacular (if not globally / computationally default) formats.
@ezwelty
I would suggest adding NOT RECOMMENDED to any format on this iteration and we can increase the strictness on next iterations. Personally, I'm favour of complete removal of any non fully interoperable parts of the spec but I think that doing so step-by-step is more realistic.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This pull request is based on comments in frictionlessdata/datapackage#487 and tries to apply the least invasive and non-breaking changes. It extends default
datetime
formatting although it keeps simpledate
andtime.
It might be too late to remove
pattern
andany
formats because of backward-compatibility requirements but what if we add a note that it'sRECOMMENDED
always use default formats (or even usingSHOULD
)?