Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Table Dialect specification #41

Merged
merged 24 commits into from
Apr 3, 2024
Merged

Table Dialect specification #41

merged 24 commits into from
Apr 3, 2024

Conversation

roll
Copy link
Member

@roll roll commented Feb 22, 2024

Copy link

cloudflare-workers-and-pages bot commented Feb 22, 2024

Deploying datapackage with  Cloudflare Pages  Cloudflare Pages

Latest commit: 698f64b
Status: ✅  Deploy successful!
Preview URL: https://75bde7b4.datapackage.pages.dev
Branch Preview URL: https://697-table-dialect.datapackage.pages.dev

View logs

@nichtich
Copy link

I object the apparent renaming of established CSV Dialect to Table Dialect and the kind of referencing CSV Dialect like an outdated specification, but this may be based on misreading and can be changed later on.

@roll
Copy link
Member Author

roll commented Feb 23, 2024

@nichtich
That's basically a new specification so I would not call it renaming. I'll update the wording regarding CSV Dialect

@roll
Copy link
Member Author

roll commented Mar 11, 2024

Hi @peterdesmet,

can you please take a look at this one as well?

@roll roll added the candidate label Mar 28, 2024
@roll roll changed the title First version of the Table Dialect specification Table Dialect specification Mar 28, 2024
@roll
Copy link
Member Author

roll commented Mar 28, 2024

@pschumm
@khusmann
@pwalsh
Hi, can you please review? That is the last proposal that would be great to include to the draft release on April 1 🚀

@roll
Copy link
Member Author

roll commented Mar 28, 2024

Probably it's easier to use a preview version - https://697-table-dialect.datapackage.pages.dev/specifications/table-dialect/

@peterdesmet
Copy link
Member

I noticed all CSV Dialect properties are included in Table Dialect, except for caseSensitiveHeader and csvddfVersion. Why is that?

@roll
Copy link
Member Author

roll commented Mar 28, 2024

@peterdesmet
I think in the context of Data Package (v1) caseSensetiveHeader had no real sense as it was kinda a validation option and didn't really belong to the dialect. As of now, we have schema.fieldsMatch it seems to be this option makes sense again regarding the name-based matching. I'll add it now

Related to csvddfVersion -- we're changing the versioning model so probably this one is not needed but because Data Package descriptors are open regarding custom properties not mentioning it in Table Dialect still make it 100% valid to have

@roll
Copy link
Member Author

roll commented Mar 28, 2024

@peterdesmet
I dived deeper in the caseSensetiveHeader property and it seems kinda problematic one:

  • it defaults to case insensitive headers
  • it has never been implemented in frictionless-py, especially with this default
  • so in frictionless-py, the header is always case sensitive (which I think is expected behavior for majority of people)

How does it work in frictionless-r? WDYT we're better to do with it?

@peterdesmet
Copy link
Member

caseSensitiveHeader is ignored in frictionless-r. I agree that default false is confusing. My take would be to drop this property altogether and only add it when there are use cases.

@roll
Copy link
Member Author

roll commented Mar 28, 2024

Thanks, I've updated the note

@roll
Copy link
Member Author

roll commented Apr 3, 2024

ACCEPTED by WG (7/9)

@roll roll merged commit d1debbb into main Apr 3, 2024
2 checks passed
@roll roll deleted the 697/table-dialect branch April 3, 2024 08:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table Dialect Spec Multi-line header rows Support ignoreRows for TabularResource
6 participants