Fix schema.fieldsMatch
#975
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
roll
commented
Sep 17, 2024
•
roll
commented
- fixes Difference beteween standard and JSON schema (fieldsMatch) #965
- bootstraps new version releasing approach
Deploying datapackage with
|
| Latest commit: |
830fed6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://02e803fe.datapackage-6gp.pages.dev |
| Branch Preview URL: | https://965-fix-fields-match.datapackage-6gp.pages.dev |
|
Hi @peterdesmet, can you please take a look? |
This was referenced Sep 17, 2024
peterdesmet
requested changes
Sep 18, 2024
There was a problem hiding this comment.
Actual change looks good (and is as discussed in 965).
Regarding the release:
- I think we need to gather a number of fixes before we release a version. The release should be approved by the WG
- Depending on how the website-build and other CLI is triggered, I would merge to a
2.1branch, rather than to main, so we don't publish a 2.1 version that is not complete.
| @@ -6,6 +6,14 @@ sidebar: | |||
|
|
|||
| This document includes all meaningful changes made to the **Data Package standard**. It does not cover changes made to other documents like Recipes or Guides. | |||
|
|
|||
| ## v2.1 | |||
|
|
|||
| > Sep 17, 2024 | |||
There was a problem hiding this comment.
To update: release should be approved by WG.
| @@ -12,7 +12,7 @@ sidebar: | |||
| </tr> | |||
| <tr> | |||
| <th>Profile</th> | |||
| <td><a href="/profiles/2.0/datapackage.json">https://datapackage.org/profiles/2.0/datapackage.json</a></td> | |||
| <td><a href="/profiles/2.1/datapackage.json">https://datapackage.org/profiles/2.1/datapackage.json</a></td> | |||
There was a problem hiding this comment.
Might be good to make this table a Markdown table (assuming it is supported by the static website generator). That way the profile can just be referenced as:
<https://datapackage.org/profiles/2.1/datapackage.json>
Guaranteeing there is no discrepancy between the displayed URL and link
|
Thanks! I agree @peterdesmet BTW @sapetti9 can you please ask OKFN to give me (gmail email) access to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.