Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1611 incorrect errors when validating data with a missiing required column #1620

Merged
merged 12 commits into from
Jan 29, 2024
Merged

Fix 1611 incorrect errors when validating data with a missiing required column #1620

merged 12 commits into from
Jan 29, 2024

Commits on Jan 15, 2024

  1. TDD: add test case with missing required header and schema_sync=True … 

    …detector option in validation of a table resource: test fails
    @amelie-rondot
    amelie-rondot committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    bdccd6c View commit details
    Browse the repository at this point in the history

  2. TDD: fix test case by removing fields info related to missing labels … 

    …in creation of row_stream: test passes
    @amelie-rondot
    amelie-rondot committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    49ddefd View commit details
    Browse the repository at this point in the history

  3. Add test case for validation TableResource with schema_sync=True dete… 

    …ctor option with two missing required header: test passes
    @amelie-rondot
    amelie-rondot committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    2d1a6b0 View commit details
    Browse the repository at this point in the history

  4. Refacto: factorize test cases and rename test function

    @amelie-rondot
    amelie-rondot committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    243b3bd View commit details
    Browse the repository at this point in the history

  5. Refacto: update field_info directly in row_stream local function just… 

    … before processing Row creation
    @amelie-rondot
    amelie-rondot committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    bf2bb00 View commit details
    Browse the repository at this point in the history

  6. Sort imports

    @amelie-rondot
    amelie-rondot committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    23e4231 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Merge branch 'main' into Fix-1611-incorrect-errors-when-validating-da… 

    …ta-with-a-missiing-required-column
    @roll
    roll authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    5e4e245 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into Fix-1611-incorrect-errors-when-validating-da… 

    …ta-with-a-missiing-required-column
    @roll
    roll authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    eca4381 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Linting: lint and format files

    @amelie-rondot
    amelie-rondot committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    4dc6274 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Merge branch 'frictionlessdata:main' into Fix-1611-incorrect-errors-w… 

    …hen-validating-data-with-a-missiing-required-column
    @amelie-rondot
    amelie-rondot authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    4ba3e64 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Refacto: Move added block dealing with missing required labels in __o… 

    …pen_run_stream() TableResource method
    @amelie-rondot
    amelie-rondot committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    42872cc View commit details
    Browse the repository at this point in the history

  2. Add test cases

    @amelie-rondot
    amelie-rondot committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    e2a910e View commit details
    Browse the repository at this point in the history