Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing checklist argument for validating resource #1677

Conversation

adrienDog
Copy link
Contributor

@adrienDog adrienDog commented Sep 4, 2024

Very important and simple fix to make sure the skip_errors, and overall checklist are passed down to resource.validate calls

Fixes #1639

@roll
Copy link
Member

roll commented Sep 5, 2024

Hi @pdelboca @pierrecamilleri can you please take a look?

@adrienDog
Copy link
Contributor Author

Thanks! i noticed other places to fix in that class btw, I will submit an update with unit tests

@pierrecamilleri
Copy link
Collaborator

Thanks for the fix, I can confirm the bug and the fix. The PR #1665 came up with the same solution.

Thanks! i noticed other places to fix in that class btw, I will submit an update with unit tests

I'll then wait for the update before merging, thanks !

@pierrecamilleri
Copy link
Collaborator

I've taken the initiative of adding a unit test to be able to merge this PR. Don't hesitate to reopen a PR if you want to make other changes or tests !

Thanks again for your contribution.

@pierrecamilleri pierrecamilleri merged commit 84c3ea0 into frictionlessdata:main Oct 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--skip-errors doesn't work for packages
3 participants