fix: Pandas parser does fail to parse integer or boolean only dataframes #1683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting the Series returned by
iterrows()
to a dict convertsnp.int64
type to python's nativeint
type and fixes the bug (same with booleans).if value is np.nan: value = None
to_dict
would not change the behavior ofnp.nan
conversion (see side note), so I left this code unchanged.int
s ortuple[int]
, nonp.int64
thereTimestamps
types are kept unchanged, so theif isinstance(value, pd.Timestamp):
still applies.Side note
np.nan
behavior is quite strange withdf.iterrows()
: in a number column, it will be converted tofloat("nan")
, whereas in string column it will be kept asnp.nan
. Addingto_dict()
to the row Series does not change the types.