Refactored code to depend on connection handler's #with_connection inste... #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of #connection. Any place that called #connection that did not store it in some field was changed to use #with_connection because #with_connection will create a connection, run the block that needs that connection, and then let go of the connection so that connections are held onto.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ad of #connection.
Any place that called #connection that did not store it in some field was changed to use #with_connection because #with_connection will create a connection, run the block that needs that connection, and then let go of the connection so that connections aren't held onto.
This is a WIP. I needed to comment out two test cases that were specifically looking for #connection. I know I made a lot of sweeping changes so I would greatly appreciate feedback.