Handle parser errors by emitting error and closing connection #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased on |
SimonFrings
approved these changes
Sep 1, 2022
WyriHaximus
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset makes the parser more robust by splitting on individual package boundaries and handles parser errors by emitting error and closing connection. This should have no effect for well-behaving servers, but makes our parser more robust for misbehaving servers or servers sending invalid data (intentionally or otherwise).
Together with the analysis in ticket #123 and the work done in #158, you're looking at around two days of work, enjoy!
Builds on top of #158
Refs #123