Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts Page: bulk save alerts & URL search params for both Alerts and Archive Pages #541

Merged
merged 7 commits into from
May 17, 2024

Conversation

Theodlz
Copy link
Collaborator

@Theodlz Theodlz commented Mar 16, 2024

  • URL search params to pre-set the forms and run API query for both alerts and archival lightcurves.
  • group alerts by objectID on the alerts page, to essentially get a list of objects, great for readability
  • when grouping by objectID, make rows selectable to allow bulk saving of alerts as sources to a user's groups.
  • cleanup the Archive page code

This PR requires skyportal/skyportal#4830 to be merged first (once it's ready). The idea is that if one adds sources from another survey in Fritz, it's super useful to be able to grab all ZTF alerts (within a small enough radius) in Kowalski and save them, which thanks to skyportal/skyportal#4830 allows a user to show the photometry of nearby sources on the photometry plot of any source.

TODO:

  • limit the max radius that can be used when saving sources, to maybe something like 4 arcsec?
  • make the pop-up window where a user saves alert(s) as source(s) smarter and more intuitive, showing info like "this source has already been saved to one or more groups".

@Theodlz Theodlz requested a review from mcoughlin May 10, 2024 01:40
Copy link
Contributor

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice

@Theodlz Theodlz merged commit 24225e4 into main May 17, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants