Yii2 Froala Plugin, Update in accordance with Froala PHP SDK #20
Conversation
|
|
||
| Either run | ||
|
|
||
| ``` | ||
| php composer.phar require --prefer-dist froala/yii2-froala-editor | ||
| php composer.phar require --prefer-dist froala/wysiwyg-editor-php-sdk | ||
| php composer.phar require --prefer-dist bower-asset/froala-wysiwyg-editor |
There was a problem hiding this comment.
There is a composer package as well: https://packagist.org/packages/froala/wysiwyg-editor.
| "froala/yii2-froala-editor": "^2.6.0" | ||
| "froala/yii2-froala-editor": "^2.6.0", | ||
| "froala/wysiwyg-editor-php-sdk" : "*", | ||
| "bower-asset/froala-wysiwyg-editor": "^2.6.0" |
There was a problem hiding this comment.
Same, there is a compose package: https://packagist.org/packages/froala/wysiwyg-editor.
README.md
Outdated
| @@ -132,8 +93,7 @@ For the view: | |||
| 'theme' => 'royal',//optional: dark, red, gray, royal | |||
| 'language' => 'en_gb' , | |||
| 'toolbarButtons' => ['fullscreen', 'bold', 'italic', 'underline', '|', 'paragraphFormat', 'insertImage'], | |||
| 'imageUploadParam' => 'file', | |||
| 'imageUploadURL' => \yii\helpers\Url::to(['site/upload/']) | |||
| 'imageUploadParam' => 'file' | |||
There was a problem hiding this comment.
This shouldn't be required.
composer.json
Outdated
| "rmrevin/yii2-fontawesome": "^2.0" | ||
| "rmrevin/yii2-fontawesome": "^2.0", | ||
| "froala/wysiwyg-editor-php-sdk": "*", | ||
| "bower-asset/froala-wysiwyg-editor": "^2.6.0" |
There was a problem hiding this comment.
Use the composer package.
src/Module.php
Outdated
| @@ -0,0 +1,13 @@ | |||
| <?php | |||
|
|
|||
| namespace froala\froalaeditor; | |||
There was a problem hiding this comment.
Let's user Froala\Editor
There was a problem hiding this comment.
Not sure if I understand this change, do you want something like this?
There was a problem hiding this comment.
Yes, it would be better to use Froala\Editor instead of froala\froalaeditor.
| { | ||
| // Store the image. | ||
| try { | ||
| $uploadFolder = $this->module->uploadFolder; |
There was a problem hiding this comment.
Please use 4 spaces indentation.
| class DefaultController extends Controller | ||
| { | ||
| // Without false it will give "Bad Request (#400) Unable to verify your data submission." | ||
| public $enableCsrfValidation = false; |
There was a problem hiding this comment.
Can we set CSRF and pass it along with imageUploadParams?
There was a problem hiding this comment.
Or through the requestHeaders option?
Changed namespace froala/froalaeditor to Froala/Editor
This PR focuses on changes that would add a default controller to the plugin so we can perform actions like imageUploadURL by using Froala's PHP SDK, load it through the yii routes, unlike before where we had to write a custom Controller uploadAction and Model changes, all we need is to setup a module configuration inside web.php config array and then the upload folder path could be fetched from that.