Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip dropbox file based on size #179

Merged
merged 3 commits into from
May 28, 2024
Merged

Conversation

louisabraham
Copy link
Contributor

@louisabraham louisabraham commented May 27, 2024

if the file exists and has the same size as indicated by the API, we skip it

behavior is unchanged since curl uses the -C option to resume download

if the file exists and has a greater size than indicated (weird bug I couldn't track back), we delete it

This makes the script much faster (needs only one request on already synced folders instead of one per file) and more resilient.

@louisabraham
Copy link
Contributor Author

do NOT merge yet

@louisabraham
Copy link
Contributor Author

ok to merge now! I needed to add the skipped files to the filesList.

I alos fixed another annoying bug that made lines like

* not found, deleting
rm: can't remove '*': No such file or directory

appear in the logs

@fsantini fsantini merged commit 40c14cc into fsantini:master May 28, 2024
1 check passed
@fsantini
Copy link
Owner

Thanks!

@louisabraham
Copy link
Contributor Author

I have never found a project more useful to my daily life than this one, so thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants