Add new Tag 0x0100003E, manual charging last target energy #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 17, 2024
|
@fsantini Do you need anything else here? I'd be glad to update the PR if you just drop me a hint what you're missing! |
|
Thanks! Sorry for not being responsive, too busy with many things! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending EMS_REQ_GET_MANUAL_CHARGE uncovers a new, unknown tag with value 0x0100003E. According to my current analysis, this will yield the last target energy level in Wh used for manual charging. With this fix, pye3dc will now correctly give you a response to this REQ again:
[ [ "EMS_MANUAL_CHARGE_ACTIVE", "Bool", false ], [ "EMS_MANUAL_CHARGE_START_COUNTER", "Int64", 1713369791878 ], [ "EMS_MANUAL_CHARGE_ENERGY_COUNTER", "Double64", 10.10137 ], [ "EMS_MANUAL_CHARGE_LASTSTART", "Timestamp", 1713369791.87892 ], [ "EMS_MANUAL_CHARGE_LASTTARGET", "Uint32", 10 ] ]I hope that tag name is OK, if not, let me know, then I'll change it.
fixes #109