Update list of tags and move to enum

[eikowagenknecht]

Implements #85

Moving to Enum instead of loose string references has the advantage that now only existing tags can be used and the IDE picks up on errors.

Unfortunately since "BAT_REQ_MEASURED_RESISTANCE" (0x03000130) and "BAT_RUN_MEASURED_RESISTANCE" (0x03800131) don't exist any more, I had to remove those two from the output.

But I think this is a good thing because those two were wrong anyways (see values in screenshots):

• 0x03000130 reported the avg30 current (this is not used any more, but there is 0x03800130 = BAT_INTERNAL_CURRENT_AVG30)
• 0x03800131 reported the avg30 voltage (this is now called BAT_INTERNAL_MTV_AVG30)

I can add those avg30s values to the battery results if you want. Currently those only exist on DCB level.

[vchrisb]

Thank you @eikowagenknecht! 🥇
That is a lot of change.
Can you please separate the two commits into two PRs?

[eikowagenknecht]

Ooops, I intended to do so. The other PR should be fine, but this one needs to be rebased against master. On it.

[eikowagenknecht]

Done. I also fixed the flake8 errors.

[eikowagenknecht]

Fixed the remaining two flake8 errors..

[eikowagenknecht]

Ran isort and black as well now...

[vchrisb]

please add Args and Returns to the docstring.

[vchrisb]

@eikowagenknecht do you potentially already created a script how you generated the RscpTag?
I think it would be valuable to add this somewhere to make future updates easier.

[vchrisb]

• would you mind moving rscpErrorCodes and powermeterTypes also to enum?
• may I suggest using rscptype instead of type_?

[eikowagenknecht]

@eikowagenknecht do you potentially already created a script how you generated the RscpTag? I think it would be valuable to add this somewhere to make future updates easier.

Sure, I commented and added the script. I put it into a newly created tools directory, if you want it somewhere else I'm happy to move it.

[eikowagenknecht]

• would you mind moving rscpErrorCodes and powermeterTypes also to enum?
• may I suggest using rscptype instead of type_?

All done.

[eikowagenknecht]

Seems like flake8-docstrings is used as well in the GitHub workflow. I added that requirement to the developer section of the readme.

[vchrisb]

We are getting close to merging this! 💯
Thank you for sticking to it! 🥇

[fsantini]

Congratulations :)