Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust testing #62

Merged
merged 1 commit into from
Oct 23, 2024
Merged

More robust testing #62

merged 1 commit into from
Oct 23, 2024

Conversation

ForNeVeR
Copy link
Member

  1. Now we produce container build logs on build failure (was tricky to implement but I checked and it works).
  2. Added .WithDeleteIfExists(true) to prevent wrong reuse of an obsolete app container for testing.
  3. We only collect logs from the appContainer if its state is not Undefined (I have to note I didn't check if this log collector still works, sorry).

@ForNeVeR ForNeVeR requested a review from Szer October 21, 2024 22:01
@Szer Szer merged commit dfa46b2 into fsharplang-ru:main Oct 23, 2024
2 checks passed
@ForNeVeR ForNeVeR deleted the test/deployment branch October 23, 2024 13:37
ForNeVeR added a commit to ForNeVeR/vahter-bot that referenced this pull request Oct 24, 2024
Tests: more robust logging for failed containers, destroy test container before startup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants