Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: transaction webhooks #9

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Feature: transaction webhooks #9

wants to merge 35 commits into from

Conversation

kritzl
Copy link
Contributor

@kritzl kritzl commented Jul 11, 2024 •
edited
Loading

This PR adds webhooks and a UI refresh.
Users will be able to add webhooks for specific types of transactions. This gives them the ability to build custom clients or smart home integrations.

The redesign removes scripts and styles loaded from cloudflare and google. It uses Tailwind and adds a dark mode.

ftsell and others added 21 commits July 9, 2024 16:53
@ftsell
add model for webhook configuration
266f0aa
@ftsell
wire up some basic webhook triggering and a profile page
bb10ba4
@kritzl
remove dependencies from cloudflare and google (!)
2edb00b
@kritzl
redesign templates using tailwind css
2fd818b
@kritzl
redesign templates using tailwind css
94d35f1
@kritzl
Merge remote-tracking branch 'origin/feature/redesign' into feature/r…
370a925 
…edesign
@kritzl
fix formatting
bff7240
@kritzl
fix: include browserReload when in DEBUG mode
93cb8fc
@kritzl
add tailwind to deployment process
3bd0248
@kritzl
style profile page
129bad9
@kritzl
style login page
c9b5b01
@kritzl
style login page (light mode)
364eecc
@kritzl
remove unused pipfile
995540b
@kritzl
update styles.css
e40e5b3
@kritzl
add missing npm
e3a95e1
@kritzl
update logo and footer styles
a31c368
@kritzl
Merge pull request #7 from fsinfuhh/feature/redesign
c6ff6d6 
Apply redesign
@kritzl
add development infos to README.md
4dfd552
@kritzl
remove default value for deposit
7fca44a
@kritzl
add interface to manage webhooks; call webhook
6b66b9b
@kritzl
add status codes
769b023
@kritzl kritzl marked this pull request as ready for review July 11, 2024 20:11
@kritzl kritzl requested review from ftsell and timonegk July 11, 2024 20:11
@kritzl
clean up PR
aefe303 
- remove unused .env.prod file
- remove dist folder
timonegk
timonegk approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@timonegk timonegk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a small comment.
I think it would also be good to a small explanation above the webhook form to explain what webhooks can be used for.

src/vinywaji/gui/views.py Outdated Show resolved Hide resolved
@kritzl kritzl requested a review from timonegk July 12, 2024 15:38
timonegk
timonegk reviewed Jul 12, 2024
View reviewed changes
Copy link
Member

@timonegk timonegk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you also test it with the Bit-Bots design?

.env.dev Outdated Show resolved Hide resolved
ftsell
ftsell approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@ftsell ftsell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a lot of time right now to review this in detail but since it works, we can merge this if you want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timonegk timonegk timonegk approved these changes

@ftsell ftsell ftsell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kritzl @ftsell @timonegk