Pin FSharp.Core dependency

[bartelink]

Triggered by SwensenSoftware/unquote#169

• Add an explicit FSharp.Core dependency
• Adjust inadvertent leak of Dotnet.ReproducibleBuilds into the package deps
• Remove misleading inert superseded settings

[samritchie]

Build failure looks like it’s related to the StructuredLogger version in build.fsx, I’ll see if I can work out what it should be

[samritchie]

Looks like bumping it to 2.2.206 should work - @bartelink is it easier for you to update your branch?

[samritchie]

Also note I’ve considered bumping FSharp.Core to 6.0.7 as it looks like it will make life easier with tasks - I’ve been working on streams support using a Task based API. Not sure of the tradeoffs here though - open to suggestions.

[bartelink]

I think 6.0.7 is a good call - there's probably the odd gap closed in Arrray, Seq and stuff too
You should be able to push to my branch if you gh pr to retrieve it (and 101 other ways) - in general feel free to do that, but I'll try now
Yes it dos stand to reason the template is gone
my main thing in all of this is for the package not to get a random dependency update due to unqote some day

[bartelink]

(Giving up for now; have time-sensitive stuff this side...)

[samritchie]

Thanks @bartelink - I’m off grid the next few days but will have a look on the weekend. On 10 Apr 2024, at 2:09 PM, Ruben Bartelink ***@***.***> wrote:  (Giving up for now; have time-sensitive stuff this side...) — Reply to this email directly, view it on GitHub<#75 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AACLRRCUXH33AJILVHHZGKDY4TJQ3AVCNFSM6AAAAABF6E5DBOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBWGYYDGMRTGI>. You are receiving this because you commented.Message ID: ***@***.***>

[bartelink]

Thanks; it's not time sensitive from my perspective.
If unquote reduces dependency to 6.0.0, probably updating unquote can be done as a follow-up to include in the next release
... or not yet, depending on when you want to do task stuff

[bartelink]

@samritchie Thanks to hard work from Stephen, we can up the Unquote dependency to v 7.0.1 (if we are willing to up FSharp.Core dep to 6.0.0).

I feel it would be good to get this in now though, in advance of that, so the minimum FSharp.Core dependency we force directly from this package is explicit, vs being an accidental thing implied by the Unquote dependency. see https://www.nuget.org/packages/fsharp.aws.dynamodb#dependencies-body-tab

Alternately, we could let the Unquote dependency float (and trust there not to be breaking changes in its interface) by changing to specify: nuget Unquote 6.1.0 in paket.dependencies.

I have no particular preference; my main desire is that the transitive dependencies forced by this package to be something that has been a conscious choice (and in general be minimal)

[samritchie]

@bartelink I’ll merge this & push a release so we can then move on bumping Core. I may need input on the observability work - I’ve seen mention of System.Diagnostics.DiagnosticSource not properly supporting some netstandard2.0 platforms, but I’m not sure I follow the implications.