This repository has been archived by the owner on Apr 8, 2023. It is now read-only.
Add discard button on document creation #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please rebase this pr? this would make testing with redis a lot easier |
Co-authored-by: Felix Auringer <[email protected]>
Co-authored-by: Felix Auringer <[email protected]>
Co-authored-by: Felix Auringer <[email protected]>
frcroth
force-pushed
the
feature/discard-button
branch
from
8c8b18c
to
32fc265
Compare
Ok |
janno42
reviewed
Mar 31, 2021
Comment on lines
37
to
38
| {% endif %} | ||
| {% if document|num_revisions > 0 %} |
There was a problem hiding this comment.
Suggested change
| {% endif %} | |
| {% if document|num_revisions > 0 %} | |
| {% elif document|num_revisions > 0 %} |
Comment on lines
327
to
329
| {% endif %} | ||
|
|
||
| {% if document|num_revisions > 0 %} |
There was a problem hiding this comment.
Suggested change
| {% endif %} | |
| {% if document|num_revisions > 0 %} | |
| {% elif document|num_revisions > 0 %} |
_1327/documents/views.py
Outdated
| @@ -521,12 +538,16 @@ def delete_autosave(request, title): | |||
|
|
|||
| # first check that the user actually may change this document | |||
There was a problem hiding this comment.
the comments ("first ..." and "second ...") need to be updated
|
|
||
| # second check that the supplied autosave id matches to the document and has been created by the user | ||
| autosave_id = request.POST['autosave_id'] | ||
| autosave = get_object_or_404(TemporaryDocumentText, id=autosave_id) | ||
| autosaves_for_object_and_user = TemporaryDocumentText.objects.filter(document=document, author=request.user) | ||
|
|
||
| # a new document does not have permissions, just check if the autosave author is correct |
There was a problem hiding this comment.
this comment does not explain why a permission check is done nevertheless if the author does not match
T4rikA
approved these changes
May 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #765, #766