Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use localized page tree for menu, add language chooser to footer #380

Merged
merged 3 commits into from
Sep 4, 2023
Merged

use localized page tree for menu, add language chooser to footer #380

merged 3 commits into from
Sep 4, 2023

Conversation

jeriox
Copy link
Contributor

@jeriox jeriox commented Aug 15, 2023

@frcroth this produces a menu with the english titles with my local dataset. Could you please test against the production dump?

@jeriox jeriox requested a review from frcroth August 15, 2023 19:18
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5870863319

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 61.751%
Totals Coverage Status
Change from base Build 5811820522: 0.03%
Covered Lines: 896
Relevant Lines: 1451
💛 - Coveralls

@jeriox jeriox linked an issue Aug 15, 2023 that may be closed by this pull request
Language chooser #292
Closed
frcroth
frcroth approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@frcroth frcroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me and should not break too much if it doesn't work

@jeriox jeriox changed the title use localized page tree for menu use localized page tree for menu, add language chooser to footer Sep 4, 2023
@jeriox jeriox merged commit bfb430a into main Sep 4, 2023
8 checks passed
@jeriox jeriox deleted the english-menu branch September 4, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frcroth frcroth frcroth approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Language chooser
3 participants
@jeriox @coveralls @frcroth