Ignore lists with missing hashes on the dashboard #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about adding a hash to those lists? As of #582 we shouldn't have the need to create lists out of tenca anymore? |
|
I could imagine there might still be cases in which we want to create lists without involving tenca (internal testing or limitations other than the configurable footer), especially since there are some migrations to the underlying mailing infrastructure planned. Nevertheless, I will try adding a hash to the existing lists (that just lacked one due to the footer stuff) as soon as the PR you've referenced is in production. |
jeriox
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our production instance, there are some mailing lists that have not been created with tenca and thus are lacking the tenca hash id. This causes an error on the server when somebody who is member of such a list visits the dashboard.
This PR sets a new flag when querying the lists from tenca to prevent the error to be raised.