Nested asset imports #364
Open
Nested asset imports #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of just at the top-level asset directory
…erence issue that overrides attrs in different videos during reduce
pandringa
reviewed
Oct 30, 2024
| @@ -6,7 +6,7 @@ const DEFAULT_IMAGE_PROPS = { | |||
| // alt: '' | |||
| }; | |||
|
|
|||
| const images = sortFiles(import.meta.glob('./*.{png,jpg,jpeg,gif}', { eager: true })).reduce( | |||
| const images = sortFiles(import.meta.glob('./**/*.{png,jpg,jpeg,gif,svg}', { eager: true })).reduce( | |||
| (acc, [k, v]) => { | |||
| const [, name, count, size] = | |||
| k.match(/\/([-_\w]+)\.([0-9]+)?\.?([SMLX]+)?\.?(png|jpe?g|gif)$/) || []; | |||
There was a problem hiding this comment.
Just to note - this regex will only extract the file name (not the path). If you want to be able to reference images like image: myfolder/myimage.jpg in the ArchieML doc (or images['myfolder/myimage'] in the code), we should add a forward slash / to the character list in the first group.
On the other hand, we could definitely leave it as is — but we'd have to guarantee all filenames are unique across the folders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts path in asset index files to scan all media in subdirectories instead of just at the top-level asset directory