You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add a method fixmate on Template that will set mate flags and appropriate SAM tags. This is useful when we modify the records (e.g. clipping) in a template and want to update the tags.
One can also validate this by running both/either fgbio SetMateInformation or samtools fixmate. Probably a good idea to do both.
Tests should include templates with:
only primary records
one or both ends unmapped
secondary records (are not updated)
supplementary records (are updated)
Ideally the fixmate method on Template routes to set_pair_info and creates a new method set_pair_info_on_supplementary, as these methods are useful in their own right.
The text was updated successfully, but these errors were encountered:
- added fixmate() method
- added set_mate_info_on_supplementary() helper function
- moved builder._set_mate_info() to helper function set_mate_info()
- moved test_template_iterator.py to test_template.py (contained more than just iterator)
- added template_test_fixmate() tests
- added fixmate() method
- added set_mate_info_on_supplementary() helper function
- moved builder._set_mate_info() to helper function set_mate_info()
- moved test_template_iterator.py to test_template.py (contained more than just iterator)
- added template_test_fixmate() tests
TimD1
linked a pull request
Sep 3, 2024
that will
close
this issue
Add a method
fixmate
onTemplate
that will set mate flags and appropriate SAM tags. This is useful when we modify the records (e.g. clipping) in a template and want to update the tags.For a code example, see fgbio's
fixMateInfo
and how it uses htsjdk'ssetMateInformationOnSupplementalAlignment
. Note: we already have a methodset_pair_info
in fgpyo that will reset mate info for primary records in a pair where both records are mapped.One can also validate this by running both/either
fgbio SetMateInformation
orsamtools fixmate
. Probably a good idea to do both.Tests should include templates with:
Ideally the
fixmate
method onTemplate
routes toset_pair_info
and creates a new methodset_pair_info_on_supplementary
, as these methods are useful in their own right.The text was updated successfully, but these errors were encountered: