Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(package): migrate to ng12 #214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

sqrter
Copy link

@sqrter sqrter commented Jun 7, 2021

BREAKING CHANGE: ng12

** PR Checklist
Please check if your PR fulfills the following requirements:

** PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ x] Other... Please describe: Add support of Angular 12

** What is the current behavior?
#210

Issue Number: 210

** What is the new behavior?

** Does this PR introduce a breaking change?

[ x] Yes
[ ] No

** Other information

@sqrter sqrter requested a review from fulls1z3 as a code owner June 7, 2021 11:05
@ghost
Copy link

ghost commented Jun 7, 2021

Sider has detected 2 warnings on analyzing the commit 5c91333.

We recommend fixing them as possible by updating the dependencies, configuring the analysis tool, configuring sider.yml, turning off unused tools, and so on.

If you have problems or questions still, feel free to ask us via chat. 💬


You can turn off such notifications if unnecessary.

BREAKING CHANGE: ng12
@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #214 (5c91333) into master (6329569) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #214   +/-   ##
=======================================
  Coverage   98.75%   98.76%           
=======================================
  Files           7        7           
  Lines         161      162    +1     
  Branches       47       50    +3     
=======================================
+ Hits          159      160    +1     
  Misses          2        2           
Impacted Files Coverage Δ
packages/@ngx-meta/core/src/index.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6329569...5c91333. Read the comment docs.

@RomainMarecat
Copy link

RomainMarecat commented Jun 23, 2021

When will it be merged and released ? Your lib block my migration to ng 12, i hope you merge soon soon :)

@fulls1z3
Copy link
Owner

fulls1z3 commented Jul 8, 2021

@sqrter @RomainMarecat need help with these PR's, especially with ng-packagr is failing. once done aim is first to ng 10 and then eventually to ng11 and ng12 (supporting all intermediate versions)

and finally we're showcasing it on fulls1z3/universal#755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants