Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(package): migrate to ng12 #215

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JonnyBGod
Copy link

** PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

** What is the current behavior?
Does not compile for Angular 12 apps.

Issue Number: N/A

** What is the new behavior?

Should work with Angular 12.

** Does this PR introduce a breaking change?

[ ] Yes
[x] No

@JonnyBGod JonnyBGod requested a review from fulls1z3 as a code owner June 10, 2021 16:38
@ghost
Copy link

ghost commented Jun 10, 2021

Sider has detected 2 warnings on analyzing the commit 4f86860.

If the errors persist even after retrying, the following actions may resolve them:

If you still have problems, feel free to ask us via chat. 💬


You can turn off such notifications if unnecessary.

@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #215 (4f86860) into master (6329569) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
- Coverage   98.75%   98.74%   -0.02%     
==========================================
  Files           7        6       -1     
  Lines         161      159       -2     
  Branches       47       49       +2     
==========================================
- Hits          159      157       -2     
  Misses          2        2              
Impacted Files Coverage Δ
packages/@ngx-meta/core/src/index.ts 100.00% <0.00%> (ø)
...ngx-meta/core/src/models/page-title-positioning.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6329569...4f86860. Read the comment docs.

@JonnyBGod
Copy link
Author

@fulls1z3 need anything extra for this to be merged?

@JonnyBGod
Copy link
Author

@fulls1z3 Any news on this? We are really stuf at this point waiting for this lib to support Angular 12.

@fulls1z3
Copy link
Owner

fulls1z3 commented Jul 8, 2021

@JonnyBGod need help with these PR's, especially with ng-packagr is failing. once done aim is first to ng 10 and then eventually to ng11 and ng12 (supporting all intermediate versions)

and finally we're showcasing it on fulls1z3/universal#755

@JonnyBGod
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants