-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(package): migrate to ng12 #215
base: master
Are you sure you want to change the base?
Conversation
Sider has detected 2 warnings on analyzing the commit 4f86860. If the errors persist even after retrying, the following actions may resolve them:
If you still have problems, feel free to ask us via chat. 💬 You can turn off such notifications if unnecessary. |
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
==========================================
- Coverage 98.75% 98.74% -0.02%
==========================================
Files 7 6 -1
Lines 161 159 -2
Branches 47 49 +2
==========================================
- Hits 159 157 -2
Misses 2 2
Continue to review full report at Codecov.
|
@fulls1z3 need anything extra for this to be merged? |
@fulls1z3 Any news on this? We are really stuf at this point waiting for this lib to support Angular 12. |
@JonnyBGod need help with these PR's, especially with ng-packagr is failing. once done aim is first to ng 10 and then eventually to ng11 and ng12 (supporting all intermediate versions) and finally we're showcasing it on fulls1z3/universal#755 |
** PR Type
What kind of change does this PR introduce?
** What is the current behavior?
Does not compile for Angular 12 apps.
Issue Number: N/A
** What is the new behavior?
Should work with Angular 12.
** Does this PR introduce a breaking change?