Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test on ubuntu, macos, windows. Support py3.9-3.12 #7

Merged
merged 15 commits into from
Nov 20, 2024

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Nov 7, 2024

just curious to see what breaks

fixes #9

@tlambert03
Copy link
Member Author

black and mypy are failing, but that is another PR (#8)

@tlambert03
Copy link
Member Author

tlambert03 commented Nov 7, 2024

some issues, from witty...

  • fcntl is not available on windows. The substitute is win32api calls... but that's not a drop-in replacement. so that will take some doing.
    C:\hostedtoolcache\windows\Python\3.11.9\x64\Lib\site-packages\witty\compile_module.py:2: in <module>
        import fcntl
    E   ModuleNotFoundError: No module named 'fcntl'
    
  • distutils is no longer available in python 3.12+ ... so direct setuptools dependencies should be used instead

but looks like *nix platforms on 3.9-3.11 are fine

@tlambert03
Copy link
Member Author

the witty issues were patched in funkelab/witty#2

@tlambert03 tlambert03 changed the title test: run more tests test: test on ubuntu, macos, windows. Support py3.9-3.13 Nov 7, 2024
@tlambert03
Copy link
Member Author

tlambert03 commented Nov 7, 2024

looks like this package can't support python 3.13 yet because cheetah3 uses cgi which is removed in python 3.13. See CheetahTemplate3/cheetah3#63 for progress

@tlambert03 tlambert03 changed the title test: test on ubuntu, macos, windows. Support py3.9-3.13 test: test on ubuntu, macos, windows. Support py3.9-3.12 Nov 7, 2024
@tlambert03
Copy link
Member Author

ok everything is now almost working across all platforms and python versions. The last holdout is windows, and it's because I can't yet figure out how to get the <stdatomic.h> include working on windows. If simply define RTREE_NOATOMICS when compiling, then everything also works on windows (which is great!). I think we should just do that for now... but that requires a change in witty... which is what prompted funkelab/witty#3

@tlambert03
Copy link
Member Author

All working now, but with the caveat on windows that we use no atomics

@tlambert03 tlambert03 merged commit 7f48cdd into funkelab:main Nov 20, 2024
13 checks passed
@tlambert03 tlambert03 deleted the tests branch November 20, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in local compilation on apple silicon
1 participant