Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverting to 3.12 until RTD supports 3.13 #152

Closed
wants to merge 4 commits into from
Closed

Reverting to 3.12 until RTD supports 3.13 #152

wants to merge 4 commits into from

Conversation

tabedzki
Copy link
Contributor

No description provided.

@tabedzki
Copy link
Contributor Author

@funkyfuture "furo" is not detected as a theme which causes the docs to not build properly

funkyfuture
funkyfuture requested changes Oct 16, 2024
View reviewed changes
Copy link
Owner

@funkyfuture funkyfuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't change builds (Dockerfiles' base images) and the workflow. they have no impact on the RTD build.

.readthedocs.yml Show resolved Hide resolved
@tabedzki
Copy link
Contributor Author

If the pyproject.toml and the poetry.lock are set for Python 3.13, would the build for RTD fail due to being 3.12?

@funkyfuture funkyfuture mentioned this pull request Oct 17, 2024
Merged
@funkyfuture
Copy link
Owner

If the pyproject.toml and the poetry.lock are set for Python 3.13, would the build for RTD fail due to being 3.12?

yes, because Python package installers would deny an installation of the project itself.

i'm closing this pr in favor of #154.

@funkyfuture funkyfuture mentioned this pull request Oct 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@funkyfuture funkyfuture funkyfuture requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tabedzki @funkyfuture