-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add management commands #194
base: master
Are you sure you want to change the base?
Conversation
c41444e
to
4e25e60
Compare
b4c86e7
to
718e4d4
Compare
Hi @furlongm, I am revisiting this PR since you appear to be active in Patchman again. Should I rebase to current develop and work on merging this PR? Do you find it a good idea? |
A rebase on develop would make it clearer what's in the PR. For the commands, I'm not sure if they are better as part of the For setting the secret key, it's useful to be able to do that without the app being fully functional (like when installing from deb or rpm). The createsuper command might also be useful there though. So not sure where they should go really, or what is best practice in this case? |
4fa0b87
to
5bff794
Compare
@furlongm I proceeded with the rebase. The main reason behind these commands, is the Helm Chart I have already developed. Inside that Helm Chart, there are some Jobs which are using the Patchman Docker image to prepare Patchman deployment. For example, setting the secret key, applying migrations, creating superuser with password (this is needed as long as Patchman stays in Django < 3.0. They added it to Django > 3.0 https://docs.djangoproject.com/en/3.0/ref/django-admin/#createsuperuser) |
@furlongm Hi Marcus. Did you have the chance to take a look here? This acts as a kind reminder. |
9ba0084
to
c5d821e
Compare
9009f46
to
76e3492
Compare
d3be836
to
2fab942
Compare
4d964df
to
22f1d99
Compare
5ed6ccc
to
2ae3a23
Compare
@skatsaounis apologies for the delay in replying! I released v2 with a lot of the django updates in it. Could you rebase this PR onto master? |
@furlongm feel free to take a look again |
This MR adds the following management commands:
createsuperuser_with_password
: Gives the option to create superuser with password from the CLIset_secret_key
: sets theSECRET_KEY
. It copies the existing functionality ofpatchman-manage
set_rdns_check
: It sets rDNS check for hosts