Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature native facebook login #44

Open
wants to merge 7 commits into
base: feature-NativeFacebookLogin
Choose a base branch
from

Conversation

COCPORN
Copy link

@COCPORN COCPORN commented Jan 27, 2017

For getting the actual string accesstoken, this seems to work for Android, iOS implementation not started yet, but is probably similar and trivial

Olle Fredriksson and others added 7 commits June 28, 2016 12:40
The main functionality is now in the FacebookLogin Uno project
Otherwise we get strange crashes on certain devices in certain
orientations.
…veFacebookLogin

Conflicts:
	Samples/NativeFacebookLogin/FacebookLogin/FacebookLogin.uno
	Samples/NativeFacebookLogin/FacebookLogin/FacebookLogin.unoproj
	Samples/NativeFacebookLogin/README.md
@COCPORN COCPORN requested a review from ollef January 27, 2017 18:38
Copy link
Contributor

@ollef ollef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks!

This is nice! Precisely what the sample was missing.

Would you like to do the iOS implementation as well or should we take over?

@COCPORN
Copy link
Author

COCPORN commented Jan 30, 2017

Unless it is a rush, I can look at the iOS implementation also. Then we can get to the bottom of that issue I had previously about getting it to work with fuse preview also.

@ollef
Copy link
Contributor

ollef commented Jan 30, 2017

Excellent, thanks!

@petterroea
Copy link
Contributor

Is this finished yet? Documentation is linking to it, but it is not yet on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants