New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs and Improve Native Rendering for Image, Circle and Shadow #1507

Open

ichan-mb wants to merge 2 commits into fuse-open:master from ichan-mb:fix_rendering

Member

ichan-mb commented Jan 9, 2025

Adds couple native rendering improvement for:

fix bug on<Image /> component on iOS when deal with image content alignment and component scaling (revert PR: Fix Image bounds in NativeViewHost on iOS #1341)

fix bug when drawing a stroke on a<Circle /> when the circle is not a full circle. For example:

<Circle ux:Name="rotatingStroke" Width="50" Height="50" StartAngleDegrees="-45" EndAngleDegrees="45">
    <Stroke Width="2" Color="Blue" />
</Circle>

Change implementation Shadow drawing <Shadow /> on Android using Drawable instead of View's elevation property. Elevation property is messing up with Z-Index.

This PR contains:

Changelog
Documentation
Tests

ichan-mb added 2 commits

November 23, 2024 21:28


          fix shadow, circle and image rendering

c07d3b9


          android native shadow improvement

1b9b87d

Member

mortend commented Jan 11, 2025

AppVeyor test log:

Since you ran multiple projects, here is a summary:
From 35 projects, ran 1215 tests, 1 failed.
  Failed:  Fuse.Navigation.Test.NavigatorTest.JsInterface
Command exited with code 1

Might be a spurious failure. I am not able to retry in AppVeyor, so can you force-push the branch instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet