Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GUI #294

Merged
merged 29 commits into from
Jan 13, 2023
Merged

Adding GUI #294

merged 29 commits into from
Jan 13, 2023

Conversation

shimwell
Copy link
Member

just adding a draft gui, not ready for a release but should trigger a cloud deployment

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #294 (6afc0e1) into main (4cf9f64) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #294   +/-   ##
=======================================
  Coverage   96.50%   96.50%           
=======================================
  Files          82       82           
  Lines        5405     5405           
=======================================
  Hits         5216     5216           
  Misses        189      189           
Impacted Files Coverage Δ
src/paramak/parametric_reactors/ball_reactor.py 98.54% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@shimwell
Copy link
Member Author

shimwell commented Jan 13, 2023

I need to looking into this further but think these failed tests are related to the recent move to OCP 7.7 which was merged into CQ master recently.

the ci with install tests and circle ci tests (which both use a docker image built a few days ago) pass
the CI with docker build and conda-build-test don't pass and i think that is because the are using the latest master from cadquery (with OCP 7.7)

This might be my tests that are wrong so I shall look into it further

@shimwell
Copy link
Member Author

Merging this PR for now but I shall continue to track the failing CI via this issue CadQuery/cadquery#1229

@shimwell shimwell merged commit 1653074 into main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant