Skip to content
This repository has been archived by the owner on May 17, 2019. It is now read-only.

Commit

Permalink
Implement CI for multiple node versions (#51)
Browse files Browse the repository at this point in the history
Implements Docker services for running against multiple node versions at once using a build arg.
Curently runs against node 8 and node 10.
  • Loading branch information
KevinGrandon authored Oct 25, 2018
1 parent 012c7f2 commit b5c47c8
Show file tree
Hide file tree
Showing 3 changed files with 37 additions and 2 deletions.
28 changes: 28 additions & 0 deletions .buildkite/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@ steps:
image-repository: 027047743804.dkr.ecr.us-east-2.amazonaws.com/uber
agents:
queue: builders
- name: ':docker: :package: node8'
plugins:
'docker-compose#v1.7.0':
build: create-fusion-app-node-last
image-repository: 027047743804.dkr.ecr.us-east-2.amazonaws.com/uber
agents:
queue: builders
- wait
- command: yarn flow check
name: ':flowtype:'
Expand All @@ -14,17 +21,38 @@ steps:
run: create-fusion-app
agents:
queue: workers
- command: yarn flow check
name: ':flowtype: node8'
plugins:
'docker-compose#v1.7.0':
run: create-fusion-app-node-last
agents:
queue: workers
- name: ':eslint:'
command: yarn lint
plugins:
'docker-compose#v1.7.0':
run: create-fusion-app
agents:
queue: workers
- name: ':eslint: node8'
command: yarn lint
plugins:
'docker-compose#v1.7.0':
run: create-fusion-app-node-last
agents:
queue: workers
- name: ':jest:'
command: yarn jest
plugins:
'docker-compose#v1.7.0':
run: create-fusion-app
agents:
queue: workers
- name: ':jest: node8'
command: yarn jest
plugins:
'docker-compose#v1.7.0':
run: create-fusion-app-node-last
agents:
queue: workers
3 changes: 2 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
FROM uber/web-base-image:1.0.8@sha256:c20637d449fa8604874e588780a6800dd05cc83028fae14c45a05186402607e5
ARG BASE_IMAGE=uber/web-base-image:2.0.0
FROM $BASE_IMAGE

WORKDIR /create-fusion-app

Expand Down
8 changes: 7 additions & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ services:
create-fusion-app:
build: .
volumes:
- .:/create-fusion-app
- '.:/create-fusion-app'
- /create-fusion-app/node_modules/
- /create-fusion-app/templates/basic/content/node_modules/
environment:
Expand All @@ -16,3 +16,9 @@ services:
- BUILDKITE_BUILD_URL
- BUILDKITE_PROJECT_SLUG
- BUILDKITE_COMMIT
create-fusion-app-node-last:
extends: create-fusion-app
build:
context: .
args:
BASE_IMAGE: 'uber/web-base-image:1.0.9'

0 comments on commit b5c47c8

Please sign in to comment.