Fix client-side onerror handling no working due to missing crossorigin attribute for CDN scripts #764
Conversation
wentsul
changed the title
test/e2e/dynamic-import-app/test.js
Outdated
| @@ -175,13 +175,6 @@ test('`fusion build` app with dynamic imports integration', async () => { | |||
| 'one extra script after loading new route' | |||
| ); | |||
|
|
|||
| t.ok( | |||
There was a problem hiding this comment.
The reason this crossorigin logic exists is because of:
webpack/webpack#6972 (comment)
So this test is verifying that when not using a CDN, no crossorigin attributes are set. I don't think we want to delete these tests. I think this test should remain unchanged.
Instead, there are tests that do use a CDN, and we should verify that crossorigin attributes are set. As you point out, these assertions would probably currently fail.
There was a problem hiding this comment.
added tests for CDN case if we want to go that route.
plugins/ssr-plugin.js
Outdated
| @@ -114,8 +114,8 @@ const SSRBodyTemplate = createPlugin/*:: <SSRBodyTemplateDepsType,SSRBodyTemplat | |||
|
|
|||
| for (let url of criticalChunkUrls) { | |||
| const crossoriginAttr = url.startsWith(__webpack_public_path__) | |||
There was a problem hiding this comment.
Now I'm thinking that this condition might not be the correct thing to check against, since __webpack_public_path__ could be a CDN. Perhaps it should be url.startsWith("/"), but I suppose that doesn't handle the case where the absolute url is same-origin (although this case might not matter in practice).
There was a problem hiding this comment.
It looks like the legacy ssr template used webpackPublicPath.startsWith('http') which is similar to what you mentioned. What about checking forCDN_URL?
const crossoriginAttr = process.env.CDN_URL ? ' crossorigin="anonymous"' : '';
wentsul
force-pushed
the
crossorigin-patch
branch
from
bdbc84f
to
85918ca
Compare
wentsul
force-pushed
the
crossorigin-patch
branch
from
85918ca
to
5f6b943
Compare
rtsao
changed the title
Couple things to note:
__webpack_public_path__but not sure if it should always be set for "critical chunk" scripts.el.crossOrigin === 'anonymous'was failing so I'm assuming there are other scripts.