This repository has been archived by the owner on May 17, 2019. It is now read-only.
Fix translations endpoint in development for named chunks #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtsao
changed the title
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
==========================================
- Coverage 86.08% 85.47% -0.62%
==========================================
Files 5 5
Lines 115 117 +2
Branches 28 29 +1
==========================================
+ Hits 99 100 +1
Misses 10 10
- Partials 6 7 +1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
==========================================
- Coverage 86.08% 85.47% -0.62%
==========================================
Files 5 5
Lines 115 117 +2
Branches 28 29 +1
==========================================
+ Hits 99 100 +1
Misses 10 10
- Partials 6 7 +1
Continue to review full report at Codecov.
|
AlexMSmithCA
approved these changes
Apr 4, 2019
|
Triggered Fusion.js build verification: https://buildkite.com/uberopensource/fusion-release-verification/builds/1829 |
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In development, chunk ids may have string names.
This fixes the following failing e2e test: fusionjs/fusion-cli#754