fix: always close the GHA output file

futurice · Nov 12, 2024 · 7cd1473 · 7cd1473
1 parent 620936f
commit 7cd1473
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/cmd/action/main.go b/cmd/action/main.go
@@ -24,6 +24,7 @@ func main() {
 
 	output, err := os.OpenFile(os.Getenv("GITHUB_OUTPUT"), os.O_APPEND|os.O_WRONLY, 0644)
 	checkErr(err)
+	defer output.Close()
 
 	// Write contents to the output file and to stdout
 	out := io.MultiWriter(os.Stdout, output)
@@ -49,8 +50,6 @@ func main() {
 	err = output.Sync()
 	checkErr(err)
 
-	output.Close()
-
 	// Map all non error exit codes to 0 so that Github Actions job does not fail
 	if exitCode != cli.ExitCodeError {
 		os.Exit(cli.ExitCodeOK)