[PANC-71] Create mock Airtel Api. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanchit-0
force-pushed
the
mock-airtel-api
branch
from
6600749
to
748b60d
Compare
sanchit-0
commented
Jul 16, 2024
| if (transactionId.equals(transactionIdSuccessful)) { | ||
| message = TransferStatus.SUCCESSFUL.name(); | ||
| status = TransactionStatus.TS.name(); | ||
| code = HttpStatus.OK.toString(); |
There was a problem hiding this comment.
The code now has the value 200 Ok instead of 200 is that fine? Otherwise I think we have to create a seperate enum for response codes.
sanchit-0
force-pushed
the
mock-airtel-api
branch
2 times, most recently
from
abb14b6
to
75432d3
Compare
| @@ -0,0 +1,5 @@ | |||
| package org.mifos.connector.airtel.mockairtel.utils; | |||
|
|
|||
| public enum TransactionStatus { | |||
There was a problem hiding this comment.
Why this enum is required? You can use TransferStatus enum here.
| return airtelMockController.getTransactionStatus(transactionId); | ||
| } | ||
|
|
||
| @PostMapping("/merchant/v2/payments/") |
There was a problem hiding this comment.
remove this extra '/' from the endpoint
sanchit-0
force-pushed
the
mock-airtel-api
branch
from
75432d3
to
b3421ea
Compare
sanchit-0
force-pushed
the
mock-airtel-api
branch
from
b3421ea
to
8041252
Compare
sanchit-0
force-pushed
the
mock-airtel-api
branch
from
8041252
to
27b91ef
Compare
sanchit-0
commented
Aug 5, 2024
logoutdhaval
approved these changes
Aug 5, 2024
| @@ -41,7 +45,7 @@ dependencies { | |||
| annotationProcessor 'org.projectlombok:lombok' | |||
| testImplementation 'org.springframework.boot:spring-boot-starter-test' | |||
| testRuntimeOnly 'org.junit.platform:junit-platform-launcher' | |||
| implementation 'org.mifos:ph-ee-connector-common:1.9.1-SNAPSHOT' | |||
| implementation 'org.mifos:ph-ee-connector-common:0.0.0' | |||
There was a problem hiding this comment.
Also, update this to the released version after the jfrog issue is fixed.
There was a problem hiding this comment.
Using 0.0.0 as this PR has not been merged and new version is not released.
The response codes in the `application.yml` file have been added from the Airtel documentation. Similarly, the responses returned by the API are based on the Airtel documentation.
sanchit-0
force-pushed
the
mock-airtel-api
branch
from
27b91ef
to
2f62aad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PANC-71 Write Mock APIs for Airtel money.
This PR creates Mock Apis for following Airtel Apis:
The API specs can be found here.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Followed the PR title naming convention mentioned above.
Design related bullet points or design document link related to this PR added in the description above.
Updated corresponding Postman Collection or Api documentation for the changes in this PR.
Created/updated unit or integration tests for verifying the changes made.
Added required Swagger annotation and update API documentation with details of any API changes if applicable
Followed the naming conventions as given in https://docs.google.com/document/d/1Q4vaMSzrTxxh9TS0RILuNkSkYCxotuYk1Xe0CMIkkCU/edit?usp=sharing