StructForm widget for creating modals with a Form

[aodhan-domhnaill]

Example use case,

type Transaction struct {
	gorm.Model
	Timestamp            time.Time `fyne:"field"`
	Amount               float64   `fyne:"field"`
	Description          string    `fyne:"field"`
}

type FinancialData struct {
	db *gorm.DB
}

func (fd *FinancialData) AddTransaction(tr *Transaction) error {
	if err := fd.db.Create(&tr).Error; err != nil {
		return err
	}
	return nil
}

func main() {
	// Open a database connection using the sqlite driver
	db, err := gorm.Open(sqlite.Open("accounts.db"), &gorm.Config{})
	if err != nil {
		panic("Failed to connect to database!")
	}

	fd := data.NewFinancialData(db)

	....

	transactionModal = widget.NewStructForm(
		myWindow.Canvas(),
		data.Transaction{},
		func(s interface{}) {
			fd.AddTransaction(s.(*data.Transaction))
		},
	)

	....
}

[Bluebugs]

This is pretty cool. Just an idea here, what do you think of changing field to actually be the widget type to use. For example, you could have:

type Transaction struct {
	Timestamp            time.Time `fyne:"entry"`
	Amount               float64   `fyne:"slider:0-100"`
	Description          string    `fyne:"entry"`
        Paid                 bool      `fyne:"checkbox"`
}

I will totally accept the PR with just handling the entry type.

[aodhan-domhnaill]

That's a good idea. I'll work on a change.

[andydotxyz]

Isn't this what dialog.NewForm is for?

[Bluebugs]

Can you update the top README file and add an example in cmd?

[Bluebugs]

Can you add some documentation for all exported type?

[Bluebugs]

You do not need to store this value if you only access it from within NewStructForm.

[Bluebugs]

It could be useful to split the function in two, one to create just the form and another to pack it in a dialog.

[Bluebugs]

Isn't this what dialog.NewForm is for?

This generate the item of NewForm by using reflection. It could use NewForm internally I guess.

[andydotxyz]

I think this is confusing widgets and modal dialogs. A widget can be used in a modal dialog - or if you want to make it a modal popup then use dialog for a consistent look.

From my cursory glance it seems like this is a powerful widget that should be separated from the modality concept - so it can be used for any location.

[andydotxyz]

This is looking good, but note you have outstanding comments from @Bluebugs.

Just thinking out loud here, but did you consider extending Form instead of BaseWidget? Perhaps the NeeStructForm could even extend form - I'm not sure but I wonder if that is cleaner? (I think the CreateRenderer could directly return Form.CreateRenderer).

[andydotxyz]

Just trying to catch up on things, where did this get to @Bluebugs @aodhan-domhnaill ? It's such a cool feature, I am embarrassed that we let it sit.

[aodhan-domhnaill]

Just trying to catch up on things, where did this get to @Bluebugs @aodhan-domhnaill ? It's such a cool feature, I am embarrassed that we let it sit.

Sorry. I kind of forgot about this because life stuff. I can try to pick it up again soon