Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BoxLayout bug causing additional padding with hidden objects #4325

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix BoxLayout bug causing additional padding with hidden objects #4325

merged 1 commit into from
Oct 17, 2023

Conversation

dweymouth
Copy link
Contributor

Description:

Fixes #4259

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

@coveralls
Copy link

Coverage Status

coverage: 65.085% (+0.01%) from 65.071% when pulling a9a66f6 on dweymouth:fixes/4259 into 0635d3e on fyne-io:develop.

andydotxyz
andydotxyz approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet thanks for sorting this!

@dweymouth dweymouth merged commit 7300486 into fyne-io:develop Oct 17, 2023
10 of 11 checks passed
@dweymouth dweymouth deleted the fixes/4259 branch October 17, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dweymouth @coveralls @andydotxyz