New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use the fat icons for doctabs on mobile, that was apptabs only #4388

Merged

andydotxyz merged 4 commits into fyne-io:develop from andydotxyz:fix/removefatdoctabs

Nov 16, 2023

Member

andydotxyz commented Nov 15, 2023 •

edited

Loading

As above - big icons don't make sense on horizontal doc tabs for mobile

Checklist:

Tests included.
Lint and formatter run with no errors.
Tests all pass.

andydotxyz added 4 commits

November 15, 2023 23:11


          Don't use the fat icons for doctabs on mobile, that was apptabs only

ded5af8


          Updated test data from mobile changes

f1bb766


          Don't change the position logic for now

97ae320


          Fixing last mobile tests

144d2cf

andydotxyz requested a review from Jacalz

November 16, 2023 20:24

Jacalz approved these changes

View reviewed changes

andydotxyz merged commit 31ef3ed into fyne-io:develop

10 of 11 checks passed

andydotxyz deleted the fix/removefatdoctabs branch

November 16, 2023 20:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet