widget: make Button trigger unfocus when tapped.

[pierrec]

Fixes #5107.

Description:

Previously, widget.Button did not grab the focus when tapped, resulting in any focused widget on the canvas remaining focused. Now it does gab the focus and then releases it as this should be transient for a button.

Fixes #5107.

Checklist:

• Tests included.
• Lint and formatter run with no errors.
• Tests all pass.
  (besides language related ones)

[andydotxyz]

That's not how other widgets behave. If someone wants to switch to keyboard handling then it should start from the last item they interacted with.

This may relate to a request for "remember potential focus in case keyboard controls are used" which would be a behaviour change and would have to apply to most widgets (not Entry ;) ) in a major release like 2.6.

[pierrec]

That's not how other widgets behave. If someone wants to switch to keyboard handling then it should start from the last item they interacted with.

This may relate to a request for "remember potential focus in case keyboard controls are used" which would be a behaviour change and would have to apply to most widgets (not Entry ;) ) in a major release like 2.6.

So you are saying that clicking the button should not unfocus anything?

[andydotxyz]

That's not what I am saying.
To be consistent with other widgets when you interact with a widget it would take focus, but it would not immediately lose focus.

[pierrec]

I see. The reason I removed focus was that otherwise the button appears in focus mode (blue background with the default theme) once clicked. Is this expected?

[andydotxyz]

That is how other widgets behave isn't it?
I agree it doesn't look quite right - which is why I mentioned a discussion that had happened regarding "potentially focused" or "invisible focus" in case the keyboard handing is invoked.

[Jacalz]

I think this might be a sensible change. It seems like many applications on my computer at least do unfocus when you press a button.

[andydotxyz]

Rather than considering just the visual state we need to consider the context. When another toolkit "unfocuses" the button after tapping with a mouse what happens if you hit space or enter? What happens if you hit tab?

In my experience the item still has focus it just doesn't indicate that for this situation.

[pierrec]

So would only removing the visuals of the focus for a clicked button but keeping its focus be fine?

[andydotxyz]

So would only removing the visuals of the focus for a clicked button but keeping its focus be fine?

Sorry I missed this.
I suspect that your approach would be OK - but bear in mind it will still need the visual when using keyboard interactions.

I think that is the thing we need to balance with more than just button - focusing something because it's interacted but not necessarily highlighting it until keyboard interaction?