WIP: Improve scroll speed #5283
Draft
+218
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jacalz
reviewed
Nov 27, 2024
Comment on lines
+39
to
+60
| type EventFunc interface { | ||
| Execute() | ||
| } | ||
|
|
||
| type SimpleEventFunc func() | ||
|
|
||
| func (fn SimpleEventFunc) Execute() { | ||
| fn() | ||
| } | ||
|
|
||
| type DragEventFunc struct { | ||
| wid Draggable | ||
| ev *DragEvent | ||
| } | ||
|
|
||
| func NewDragEventFunc(wid Draggable, ev *DragEvent) *DragEventFunc { | ||
| return &DragEventFunc{wid, ev} | ||
| } | ||
|
|
||
| func (drag *DragEventFunc) Execute() { | ||
| drag.wid.Dragged(drag.ev) | ||
| } |
There was a problem hiding this comment.
I know this is a draft PR but just FYI: this adds a public API for something that I suppose only was intended to be used internally? You might want to use one of the packages in the internal/ folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
First attempt at improving scroll speed by reducing the amount of calls to Draggable.Dragged.
Big diff because it introduces an interface type for queued events to allow differentiation for optimization purposes.
References:
Checklist:
Where applicable: