Fix clicking on empty part of widget.List not unfocusing #5314
Conversation
…cus other widgets
| @@ -130,6 +130,8 @@ func (l *List) RefreshItem(id ListItemID) { | |||
| return | |||
| } | |||
| l.BaseWidget.Refresh() | |||
|
|
|||
| l.Unselect(id) | |||
There was a problem hiding this comment.
This seems like an unrelated change? Why are the semantics of RefreshItem changing to that you can't use it to refresh a selected item?
There was a problem hiding this comment.
- When the entry is focused, the list item should be unfocused, to unfocus the list item we need this
There was a problem hiding this comment.
But this code is not allowing an item to remain selected when it is refreshed - so scrolling will lose the selected status
|
I don't think a driver change is the right way to solve this. |
|
A little note on PR naming: Please avoid |
Jacalz
changed the title
| if l.focused { | ||
| l.FocusLost() | ||
| } | ||
| canvas.Focus(l) |
There was a problem hiding this comment.
the PR says it is unfocusing but this code shows focussing - is this correct?
There was a problem hiding this comment.
the PR says it is unfocusing but this code shows focussing - is this correct?
when the empty portion is clicked the widgets (Entry, list items) are getting unfocused --> the issue
This PR resolves this issue --> The widgets get unfocused when we click the empty portion
There was a problem hiding this comment.
So we should do this by unfocusing surely?
Focusing something else fixes it as a side-effect, not by actually fixing the issue!
| @@ -130,6 +130,8 @@ func (l *List) RefreshItem(id ListItemID) { | |||
| return | |||
| } | |||
| l.BaseWidget.Refresh() | |||
|
|
|||
| l.Unselect(id) | |||
There was a problem hiding this comment.
But this code is not allowing an item to remain selected when it is refreshed - so scrolling will lose the selected status
Description:
This PR fixes the issue where clicking on an empty part of the widget list does not unfocus other widgets.
Fixes #4770
Checklist: