Fix validateable items not showing error text in some cases #5324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…less they are widget.Entry or have HintText set
Jacalz
changed the title
andydotxyz
requested changes
Dec 24, 2024
There was a problem hiding this comment.
Thanks for this, I have one comment inline about if some code is needed (the comment indicates it isn't or you're not sure).
Secondly please don't add comments unless absolutely necessary. Code should be (and mostly is) clear enough itself - comments take up space and break over time.
| @@ -344,23 +338,26 @@ func (f *Form) setValidationError(err error) { | |||
| } | |||
|
|
|||
| func (f *Form) updateHelperText(item *FormItem) { | |||
| if item.helperOutput == nil { | |||
| return // Exit early if helperOutput is not initialized (shouldn't happen with the updated createInput) | |||
There was a problem hiding this comment.
If this should not happen then is the line needed?
| } | ||
| f.updateHelperText(item) // Ensure the helper text is updated |
There was a problem hiding this comment.
When methods are named clearly comments often add nothing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes the issue where error text is not displayed for Validateable items unless they are
widget.Entryor haveHintTextset.Fixes #5194
Checklist: