This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Chancing to personal fictitious numbers sv_SE #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IngWARP
changed the title
|
Hi Francois |
|
I don't have a strong opinion on this, but I'm worried because it's the only place we do that. Very few formatters use a "reserved for tests" format - most use a "looks legit". If we opt for "reserved for tests", we should be more systematic about this. Besides, I don't see what GDPR has to do with this. |
|
The testpart was added before my change I just changed the number so the test should run. |
|
Then I think it should be a new option in the formatter. Please consider people using the formatter in unit tests: your change should not break their tests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering GDPR, introduced soon, one should use fictitious numbers