Skip to content

Commit

Permalink
Explain what has become of separate-front-target-dir
Browse files Browse the repository at this point in the history
The change in leptos-rs#216 was not actionable and contradicted the way the
option was documented in the README.

See leptos-rs#203 and leptos-rs#217.
  • Loading branch information
g2p committed Feb 8, 2024
1 parent 6569c2c commit a4da7a8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ lib-profile-dev = "my-debug-profile"

# Fixes cargo bug that prevents incremental compilation (see #203)
#
# Optional. Defaults to false
# Optional. Defaults to false prior to 0.2.3, unconditionally enabled (with the setting becoming deprecated) since 0.2.3 and #216
separate-front-target-dir = true

# Pass additional parameters to the cargo process compiling to WASM
Expand Down
6 changes: 3 additions & 3 deletions src/config/project.rs
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ pub struct ProjectConfig {
pub tmp_dir: Utf8PathBuf,

/// Deprecated. Keeping this here to warn users to remove it in case they have it in their config.
#[deprecated = "This option is deprecated. Please remove it from your config."]
#[deprecated = "This option is deprecated since cargo-leptos 0.2.3 (when it became unconditionally enabled). You may remove it from your config."]
pub separate_front_target_dir: Option<bool>,

// Profiles
Expand Down Expand Up @@ -259,8 +259,8 @@ impl ProjectConfig {

#[allow(deprecated)]
if conf.separate_front_target_dir.is_some() {
log::warn!("Depreciated the `separate-front-target-dir` option is deprecated");
log::warn!("Depreciated please remove it from your config in your Cargo.toml")
log::warn!("Deprecated: the `separate-front-target-dir` option is deprecated since cargo-leptos 0.2.3");
log::warn!("It is now unconditionally enabled; you can remove it from your Cargo.toml")
}

Ok(conf)
Expand Down

0 comments on commit a4da7a8

Please sign in to comment.