Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add src/components/MapControlButton.js #329

Merged
merged 7 commits into from
Aug 8, 2023

Conversation

Raruto
Copy link
Collaborator

@Raruto Raruto commented Feb 10, 2023

List of changes

  • refactor src/app/g3w-ol/controls/control.js and
    • extract functional component into src/components/MapControlButton.js

Related to #193 and preparatory for #85

@Raruto Raruto added the refactoring Anything which could result in a API change label Feb 10, 2023
@Raruto Raruto added this to the v3.8 milestone Feb 10, 2023
@Raruto Raruto marked this pull request as ready for review February 10, 2023 13:40
Raruto added a commit that referenced this pull request Mar 22, 2023
…apControlZoomHistory.vue`

Use same prefix as:

- #329
- #330
volterra79 added a commit that referenced this pull request Mar 30, 2023
* Add ZoomHistory Map Control

* Create ZoomHistoryMapControl.vue component

* clean up some code

* rename file: `components/ZoomHistoryMapControl.vue` --> `components/MapControlZoomHistory.vue`

Use same prefix as:

- #329
- #330

* fix computed method: `hasEmptyHistory()`

* Add i18n translation as QGIS Desktop tools

* update translations

* Fix issue on watch history.index. Remove watch property and move to methods last and next because when move map (zoom or pan) index is updated and map back to previous extent

* Set new icon

* Move zoomhistory according #388 (comment)

* 👀 jsdoc tags must be setted above each term...

..otherwise you could break your IDE intellisense

* remove duplicated function call: `_addControlToMapControlsLeftBottom`

* comments

---------

Co-authored-by: Raruto <[email protected]>
@volterra79 volterra79 modified the milestones: v3.8, v3.9 May 2, 2023
@Raruto Raruto merged commit 2b2023c into g3w-suite:dev Aug 8, 2023
@Raruto Raruto deleted the add-mapcontrolbutton-component branch August 8, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Anything which could result in a API change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants