Overall code refactoring (ES Modules) + Update gulp and other dev dependencies #35

Raruto · 2022-06-09T13:06:09Z

WIP, integrates and superseed: #34

overall replace function prototypes with native javascript classes
overall replace commonjs require() with native import() modules
refactor gulpfile.js and update to support gulp v4
refactor config.template.js (rename some variables, add comments and use fewer nested structures)
remove thousands of unused dev dependencies
remove preinstall hook (no more npm-force-resolutions)
rename some npm scripts to use a more common nomeclature (see: npm run dev and npm run build)
remove gulp task g3w-admin:client_only
rename some gulp tasks to use shorter names
remove useless path.join within gulpfile.js (nowdays filesystem scripts still works without this hack on Windows OS)
upgrade babel to version 7
add esmify package to enable support of ES6 modules within browserify
remove .babelrc and .browserslistrc files (related config are now listed within the package.json)
rename index.html templates (see: index.dev.html and index.prod.html)
split i18n config into multiple language files
install and configure eslint 8
apply airbnb style rules (see: eslint-config-airbnb-base)
avoid calling the super () constructor when not strictly necessary within javascript classes
avoid importing local files by relatively traversing project directories (eg. import foo from '../../../foo')
remove useful boostrap() function closure within main.js
remove useful test property within api.js
remove useful G3W_VERSION and production variable within applicationservice.js
updata update version to 4.0.0. within package.json
create gui/component folder and move related gui components inside that
replace _.forEach with Object.entries().forEach
remove src/g3w-ol/src folder (replaced with src/g3w-ol)

To be performed (not yet completed)

make use of vue single component (consolidate *.js and *.html files into a single .vue file)

- refactor gulpfile.js - refactor config.template.js - remove unusued dev dependencies

…stead commonjs

…ient into migration_v3_v4

- remove .babelrc - remove .browserlisrc probably not working due to: vuejs/vueify#237

…d with dev print changes

- remove `build_all` conditional - add some backcomp to previous config.template.js (v3) - remove useless `path.join` (nowdays filesystem scripts still works without this hack on Windows OS) - renamed some gulp tasks to use shorter names - delete `gulp g3w-admin:client_only` npm script

…into migration_v3_v4

… workaround. Try to find a better solution

const reg = new RegExp(`qgs:${sanitizeLayerName}\\b`, "g"); => const reg = new RegExp(`qgs:${sanitizeLayerName}`, "g");

…on is changed

…mponent

… and change all references

- remove dead code and comments - remove useful `bootstrap()` function closure - simplify error variable parsing - make use of "ApplicationTemplate" variable instead of reassining default export from `gui/app/index` to `Application`

- remove temporary `g3w` const variable (use default export instead) - remove unusued `test` property

…e it.

…v3_v4

…ove src/g3w-ol/src

a partial refactor is actually needed (or at least suggested) before complete #68 based on #35

Raruto and others added 8 commits June 9, 2022 09:23

update gulp and other dev dependencies

d980117

- refactor gulpfile.js - refactor config.template.js - remove unusued dev dependencies

first refactoring using class instead prototype and use es6 module in…

04f2835

…stead commonjs

Merge branch 'gulp-4' into migration_v3_v4

2ff32c9

Update package-lock.json

53359be

aligned engines in package.json from dev branch

9ac26c3

aligned i18n with last dev changes

71dc0af

fixed issue on refactoring prototype methods to class methods

3ed98d7

Merge branch 'migration_v3_v4' of https://github.com/g3w-suite/g3w-cl…

4e456e5

…ient into migration_v3_v4

Raruto changed the base branch from migration_v3_v4 to dev June 9, 2022 13:06

Raruto marked this pull request as draft June 9, 2022 13:21

Raruto and others added 20 commits June 9, 2022 15:48

replace "function() =" within classes

ae5b73f

Babel 7 test

a274de8

- remove .babelrc - remove .browserlisrc probably not working due to: vuejs/vueify#237

remove require() statements within /src files

55c2d64

try again with babel 6

e701b38

include "node_modules" folder in babelify() transform

2bdd1d8

fix some relative imports

e349b1a

rename "clean" scripts

bdabea0

globally replace "){" with ") {"

442657c

fix missing "admin" script within package.json

7122cd3

vueify + esmify + babel 7

7d88926

remove global option

5b92049

remove vue3 "ref"

e6e7fad

Fixed issue on refactoring prototype to class

c83d999

Fixed issue on geolocation, meauser control (length, area) and aligne…

03c7d24

…d with dev print changes

refactored nominatim control.

fc9ba9a

alligned printconfig.js with pull request g3w-suite#38

36675a4

fixed BingLayer refactoring bug

e44fd6f

added romanian traslation to print section

8c76f8e

Merge branch 'migration_v3_v4' of https://github.com/Raruto/g3w-client …

969fa7b

…into migration_v3_v4

volterra79 and others added 23 commits June 16, 2022 17:55

fixed issue on missing context on postcompose event in ol6. Temporary…

8fd443a

… workaround. Try to find a better solution

fix issue on parsing xml response in parser.js

3705dd1

const reg = new RegExp(`qgs:${sanitizeLayerName}\\b`, "g"); => const reg = new RegExp(`qgs:${sanitizeLayerName}`, "g");

fix issue get map screenshot and geoscreenshot. Map canvas dom positi…

0bf8247

…on is changed

fix issue length and area map control

24ea7d4

replace headeritem.html and headeritem.js to headeritem vue single co…

9f22ab0

…mponent

remove old reference to headeritem.html

805e7ec

remove template attribute on headeritem component

148037b

replace lineXY.js and lineXY.html with lineXY.vue vue single component

ce822e3

replace addlayer.js and addlayer.html with addlayer.vue vue single co…

38fab27

…mponent

change api.js importing lineXY.vue component instead a lineXY.js

ec0cf63

refactor form component and its subcomponents footer, body and header…

32f0bfa

… and change all references

in case of single language in client select language on header is hide

79fc22b

refactor main.js

13de330

- remove dead code and comments - remove useful `bootstrap()` function closure - simplify error variable parsing - make use of "ApplicationTemplate" variable instead of reassining default export from `gui/app/index` to `Application`

refactor api.js

f85b20e

- remove temporary `g3w` const variable (use default export instead) - remove unusued `test` property

remove useful production variable

4e5a95e

remove useful G3W_VERSION constant

375928d

sync with dev g3w-suite@3e24135

ae77eaa

sync with dev g3w-suite@cc1be10

247cf83

major version update in package.json

705e0c6

create component folder inside gui and move all component files insid…

e8c27f9

…e it.

Merge remote-tracking branch 'origin/migration_v3_v4' into migration_…

9e57c28

…v3_v4

substitute Lodash methods _.forEach with Object.entries().forEach

ba2c866

move all subfolder and files of src/g3w-ol/src inside src/g3w-ol. Rem…

8fac441

…ove src/g3w-ol/src

Raruto added the dependencies Pull requests that update a dependency file label Jul 28, 2022

Raruto added this to the 4.0 milestone Jul 29, 2022

Raruto added a commit that referenced this pull request Aug 12, 2022

refactor gulpfile.js

5bef9e4

a partial refactor is actually needed (or at least suggested) before complete #68 based on #35

Raruto mentioned this pull request Aug 12, 2022

Refactor gulpfile.js #137

Merged

volterra79 assigned volterra79 and Raruto Sep 16, 2024

volterra79 self-requested a review September 16, 2024 12:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Overall code refactoring (ES Modules) + Update gulp and other dev dependencies #35

Overall code refactoring (ES Modules) + Update gulp and other dev dependencies #35

Raruto commented Jun 9, 2022 •

edited

Loading

Overall code refactoring (ES Modules) + Update gulp and other dev dependencies #35

Are you sure you want to change the base?

Overall code refactoring (ES Modules) + Update gulp and other dev dependencies #35

Conversation

Raruto commented Jun 9, 2022 • edited Loading

Raruto commented Jun 9, 2022 •

edited

Loading