Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iframe refactor #529

Merged
merged 5 commits into from
Dec 20, 2023
Merged

Iframe refactor #529

merged 5 commits into from
Dec 20, 2023

Conversation

Raruto
Copy link
Collaborator

@Raruto Raruto commented Dec 20, 2023

Follows: #528
Precedes: #523

Motivation

Streamlines iframe development and testing by:

  • avoiding setting up an external LAMP server for testing (at least for basic stuff)
  • move all the related code into src/services/iframe.js

New map control: "Open in Iframe" (dev mode)

image

How to test

Add the following within your local config.js:

const G3W_IFRAME = {                  // testing MESSAGE sent to "Open in iframe" map control
  id: null,
  action: 'app:getcenter',            // or 'app:getextent'
  data: { epsg: 4326 }	
};

...

devConfig() {
  g3wsdk.gui.GUI.once('iframe:message', (w, e) => { w.postMessage(G3W_IFRAME, '*') });
}

@Raruto Raruto added the refactoring Anything which could result in a API change label Dec 20, 2023
@Raruto Raruto added this to the v3.9 milestone Dec 20, 2023
@Raruto Raruto requested a review from volterra79 December 20, 2023 13:43
@Raruto Raruto merged commit 1808e66 into dev Dec 20, 2023
@Raruto Raruto deleted the iframe-refactor branch December 20, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Anything which could result in a API change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants