Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: countdown as a Quarto shortcode extension! #35
feat: countdown as a Quarto shortcode extension! #35
Changes from all commits
72ec0b8
f7838fc
7bdb1be
1a54ac7
4ac0544
ee5752e
8400c4d
f2570ed
4036e55
1aad3b7
687d41a
f0c015e
998fcc1
6434745
e9a6ef7
cce2792
36ad034
8db8c68
df21147
d4d7978
3639040
71d83af
a116aca
381b94e
2dd2da9
e737fea
e0ac982
ac89497
ef9f405
69df9f5
369f018
706af32
4951038
98a26bb
1e72c36
34ec998
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started thinking about how we'd replace prismatic and these lines kind of hint at where my head is at.
First, we definitely do not need a prismatic replacement in the lua filter for this PR; we can certainly iterate after merging this one.
The set up with these lines is that we could tint or shade the countdown border and text color based on the background color. I went with shading (darkening) in the CSS, but we could have tinted (lightend) as well with
rgba(255, 255, 255, 0.1)
or similar.The question is how we'd know whether we should lighten or darken. But I'm okay waiting on that as well and working it out in follow up PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking out loud, there would be a Python port coming next. So, would either of these options be acceptable to avoid moving it into the Lua filter?
calc
alongside a flag on the inline element?light-color
/dark-color
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'd really like to handle it in CSS, because that will be the easiest in the long term. Hopefully sometime soon we'll get color-contrast().
For now, I'm okay with the current approach and we can work it out in future iterations.