Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Dev1.4 to main #324

Merged
merged 22 commits into from
Jan 21, 2025
Merged

Merge Dev1.4 to main #324

merged 22 commits into from
Jan 21, 2025

Conversation

cptbtptpbcptdtptp
Copy link
Collaborator

@cptbtptpbcptdtptp cptbtptpbcptdtptp commented Jan 21, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

Summary by CodeRabbit

Release Notes for Galacean Engine Toolkit v1.4.0

Overview

This release includes several significant updates and improvements across the Galacean Engine Toolkit ecosystem.

Key Changes

  • Version Upgrade: Updated toolkit packages to version 1.4.0
  • Engine Dependency: Updated core engine dependency to version 1.4.0
  • Gizmo Enhancements:
    • Added rectangle gizmo control
    • Introduced new icon rendering capabilities
  • Shader Management:
    • Removed ShaderLab package
  • Input and Interaction:
    • Updated pointer event handling in navigation gizmo

Notable Removals

  • Removed ShaderLab package and related shader management components

CI/CD Updates

  • Updated GitHub Actions workflow for Node.js CI
  • Improved test coverage upload process

Compatibility

  • Requires Galacean Engine v1.4.0
  • Updated peer dependencies across all toolkit packages

Copy link

coderabbitai bot commented Jan 21, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request represents a significant version update across the Galacean Engine Toolkit, incrementing versions from 1.3.10 to 1.4.0 and updating dependencies. The changes span multiple packages, with a notable removal of the shaderlab package and adjustments to the GitHub Actions workflow. The update includes modifications to various toolkit components, such as gizmo controls, auxiliary lines, and icon rendering, while standardizing peer dependencies on the Galacean Engine to version 1.4.0.

Changes

File/Path Change Summary
.github/workflows/nodejs.yml Updated CI workflow to use pnpm b:all for build and npm run test-cov for testing, with new Codecov action configuration
package.json and multiple package.json files Version bumped from 1.3.10 to 1.4.0 across all packages
packages/gizmo/ Added new RectControl, Icon, and IconMaterial classes, expanded gizmo functionality
packages/auxiliary-lines/ Enhanced WireframeManager and WireframePrimitive with new shape handling capabilities
packages/shaderlab/ Entire package removed, including README, source files, and configuration

Sequence Diagram

sequenceDiagram
    participant Developer
    participant Toolkit
    participant Engine
    participant Gizmo
    participant Icon

    Developer->>Toolkit: Update to version 1.4.0
    Toolkit->>Engine: Update peer dependency
    Toolkit->>Gizmo: Add RectControl
    Gizmo->>Icon: Create new Icon class
    Icon-->>Gizmo: Icon rendering support
    Toolkit->>Developer: Enhanced toolkit capabilities
Loading

Possibly related PRs

Poem

🐰 A Toolkit's Leap of Version Grace

From 1.3 to 1.4 we race,
Shaders vanish, controls take flight,
Gizmos dancing with newfound might!

CodeRabbit's magic, version's embrace! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 340197c and ed94c80.

⛔ Files ignored due to path filters (20)
  • packages/custom-material/src/advanced-shader/thinfilm/IridescenceIndirectLight.glsl is excluded by !**/*.glsl
  • packages/shaderlab/src/shaders/BlendShape.glsl is excluded by !**/*.glsl
  • packages/shaderlab/src/shaders/Common.glsl is excluded by !**/*.glsl
  • packages/shaderlab/src/shaders/Fog.glsl is excluded by !**/*.glsl
  • packages/shaderlab/src/shaders/Light.glsl is excluded by !**/*.glsl
  • packages/shaderlab/src/shaders/Normal.glsl is excluded by !**/*.glsl
  • packages/shaderlab/src/shaders/Shadow.glsl is excluded by !**/*.glsl
  • packages/shaderlab/src/shaders/ShadowSampleTent.glsl is excluded by !**/*.glsl
  • packages/shaderlab/src/shaders/Skin.glsl is excluded by !**/*.glsl
  • packages/shaderlab/src/shaders/Transform.glsl is excluded by !**/*.glsl
  • packages/shaderlab/src/shaders/shadingPBR/AttributesPBR.glsl is excluded by !**/*.glsl
  • packages/shaderlab/src/shaders/shadingPBR/BRDF.glsl is excluded by !**/*.glsl
  • packages/shaderlab/src/shaders/shadingPBR/ForwardPassPBR.glsl is excluded by !**/*.glsl
  • packages/shaderlab/src/shaders/shadingPBR/FragmentPBR.glsl is excluded by !**/*.glsl
  • packages/shaderlab/src/shaders/shadingPBR/LightDirectPBR.glsl is excluded by !**/*.glsl
  • packages/shaderlab/src/shaders/shadingPBR/LightIndirectPBR.glsl is excluded by !**/*.glsl
  • packages/shaderlab/src/shaders/shadingPBR/LightProbe.glsl is excluded by !**/*.glsl
  • packages/shaderlab/src/shaders/shadingPBR/ReflectionLobe.glsl is excluded by !**/*.glsl
  • packages/shaderlab/src/shaders/shadingPBR/VaryingsPBR.glsl is excluded by !**/*.glsl
  • packages/shaderlab/src/shaders/shadingPBR/VertexPBR.glsl is excluded by !**/*.glsl
📒 Files selected for processing (42)
  • .github/workflows/nodejs.yml (1 hunks)
  • package.json (2 hunks)
  • packages/auxiliary-lines/package.json (2 hunks)
  • packages/auxiliary-lines/src/WireframeManager.ts (5 hunks)
  • packages/auxiliary-lines/src/WireframePrimitive.ts (2 hunks)
  • packages/controls/package.json (2 hunks)
  • packages/custom-gltf-parser/package.json (2 hunks)
  • packages/custom-material/package.json (2 hunks)
  • packages/draco/package.json (2 hunks)
  • packages/dynamic-bone/package.json (2 hunks)
  • packages/framebuffer-picker/package.json (2 hunks)
  • packages/galacean-engine-toolkit/package.json (2 hunks)
  • packages/galacean-engine-toolkit/src/index.ts (0 hunks)
  • packages/geometry-sketch/package.json (2 hunks)
  • packages/gizmo/package.json (2 hunks)
  • packages/gizmo/src/Gizmo.ts (4 hunks)
  • packages/gizmo/src/Group.ts (9 hunks)
  • packages/gizmo/src/Rect.ts (1 hunks)
  • packages/gizmo/src/Utils.ts (3 hunks)
  • packages/gizmo/src/enums/GizmoState.ts (1 hunks)
  • packages/gizmo/src/enums/GroupState.ts (1 hunks)
  • packages/gizmo/src/icon/Icon.ts (1 hunks)
  • packages/gizmo/src/icon/IconMaterial.ts (1 hunks)
  • packages/input-logger/package.json (2 hunks)
  • packages/lines/package.json (2 hunks)
  • packages/navigation-gizmo/package.json (2 hunks)
  • packages/navigation-gizmo/src/SphereScript.ts (3 hunks)
  • packages/outline/package.json (2 hunks)
  • packages/shaderlab/README.md (0 hunks)
  • packages/shaderlab/package.json (0 hunks)
  • packages/shaderlab/src/global.d.ts (0 hunks)
  • packages/shaderlab/src/index.ts (0 hunks)
  • packages/shaderlab/src/shaders/PBR.gs (0 hunks)
  • packages/shaderlab/src/shaders/index.ts (0 hunks)
  • packages/shaderlab/src/shaders/shadingPBR/index.ts (0 hunks)
  • packages/shaderlab/tsconfig.json (0 hunks)
  • packages/skeleton-viewer/package.json (2 hunks)
  • packages/stats/package.json (2 hunks)
  • packages/tween/package.json (2 hunks)
  • packages/way-point/package.json (2 hunks)
  • packages/xr/package.json (2 hunks)
  • tests/package.json (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cptbtptpbcptdtptp cptbtptpbcptdtptp merged commit 20a0d77 into main Jan 21, 2025
1 of 4 checks passed
@cptbtptpbcptdtptp cptbtptpbcptdtptp deleted the dev/1.4 branch January 21, 2025 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants