feat: integrate stableswap pallet #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Crate versions that have been updated:
Runtime version has been increased. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #612 +/- ##
==========================================
- Coverage 69.50% 69.22% -0.29%
==========================================
Files 162 163 +1
Lines 12633 12884 +251
==========================================
+ Hits 8781 8919 +138
- Misses 3852 3965 +113
☔ View full report in Codecov by Sentry. |
Roznovjak
reviewed
Jul 18, 2023
…p to 3. Once we have xyk, we extend it further
… someone wants to support then in hydra, so warning to change benchmark
# Conflicts: # Cargo.lock # integration-tests/Cargo.toml
mrq1911
requested changes
Sep 12, 2023
pallets/dca/Cargo.toml
Outdated
| @@ -34,7 +34,9 @@ hydradx-traits = { workspace = true } | |||
| hydradx-adapters = { workspace = true } | |||
| pallet-relaychain-info = { workspace = true } | |||
| pallet-ema-oracle = { workspace = true } | |||
| pallet-stableswap = { workspace = true } | |||
There was a problem hiding this comment.
DCA shoudn't be dependent on stableswap at all
traits/Cargo.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "hydradx-traits" | |||
| version = "2.6.0" | |||
| version = "2.6.1" | |||
pallets/democracy/src/lib.rs
Outdated
| @@ -179,6 +179,7 @@ pub mod weights; | |||
| use crate::traits::DemocracyHooks; | |||
| pub use conviction::Conviction; | |||
| pub use pallet::*; | |||
| pub use sp_std::vec; | |||
There was a problem hiding this comment.
wait ..what? why ?
…have better way to benchmark DCA
mrq1911
reviewed
Sep 12, 2023
| let (amount_in, _) = Self::calculate_in_amount(pool_id, asset_in, asset_out, amount_out) | ||
| .map_err(ExecutorError::Error)?; | ||
| if asset_out == pool_id { | ||
| //I wanna buy 500 shares, how much luqidity i need provide to get 500 shares |
mrq1911
reviewed
Sep 12, 2023
| Self::add_liquidity_shares(who, pool_id, amount_out, asset_in, max_limit) | ||
| .map_err(ExecutorError::Error) | ||
| } else if asset_in == pool_id { | ||
| let shares_amount = max_limit; |
mrq1911
reviewed
Sep 12, 2023
mrq1911
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.